Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SOL] Advance llvm commit #92

Merged
merged 4 commits into from
Jul 19, 2024
Merged

Conversation

LucasSte
Copy link
Collaborator

@LucasSte LucasSte commented Jul 10, 2024

There are multiple reports of stack problems in the current platform tools version. I think making an intermediate release that addresses some of the problems (e.g. increasing reliability of error messages and not allowing function calls to overwrite values in the stack) would be good at this point.

@LucasSte
Copy link
Collaborator Author

There some tweaks in this PR to fix the failing CI, because we couldn't download anymore the pre-built Docker image and the pre-built LLVM binaries from the upstream Rust repository.

Also, the compiler-builtins crate has had an update, rendering it incompatible with 1.75.0.

As we'll soon upgrade to Rust 1.79, I won't pick up this commit.

@LucasSte LucasSte requested a review from dmakarov July 19, 2024 12:08
@LucasSte LucasSte marked this pull request as ready for review July 19, 2024 12:08
Copy link
Collaborator

@dmakarov dmakarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's an option in config.toml that can be set to not download llvm binaries by the bootstrap. Anyway, approving.

@LucasSte
Copy link
Collaborator Author

I think there's an option in config.toml that can be set to not download llvm binaries by the bootstrap. Anyway, approving.

This one?

download-ci-llvm = false

It is already set to false.

@dmakarov
Copy link
Collaborator

I think there's an option in config.toml that can be set to not download llvm binaries by the bootstrap. Anyway, approving.

This one?

download-ci-llvm = false

It is already set to false.

Yes, curious why it doesn’t have any effect. Maybe for CI a completely separate config.toml is created somehow in the CI environment?

@dmakarov
Copy link
Collaborator

dmakarov commented Jul 19, 2024

it’s ok to merge this as is.

@LucasSte LucasSte merged commit 16d248c into anza-xyz:solana-1.75.0 Jul 19, 2024
13 checks passed
@LucasSte LucasSte deleted the advance-commit branch July 19, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants