-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SOL] Advance llvm commit #92
Conversation
There some tweaks in this PR to fix the failing CI, because we couldn't download anymore the pre-built Docker image and the pre-built LLVM binaries from the upstream Rust repository. Also, the compiler-builtins crate has had an update, rendering it incompatible with 1.75.0. As we'll soon upgrade to Rust 1.79, I won't pick up this commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's an option in config.toml that can be set to not download llvm binaries by the bootstrap. Anyway, approving.
This one? Line 111 in 696ef74
It is already set to false. |
Yes, curious why it doesn’t have any effect. Maybe for CI a completely separate config.toml is created somehow in the CI environment? |
it’s ok to merge this as is. |
There are multiple reports of stack problems in the current platform tools version. I think making an intermediate release that addresses some of the problems (e.g. increasing reliability of error messages and not allowing function calls to overwrite values in the stack) would be good at this point.