[SOL] Add return instructions for functions that end with unreachable #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
approved these changes
Jan 17, 2025
LucasSte
merged commit 10a96aa
into
anza-xyz:solana-rustc/18.1-2024-05-19
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SBFv3, functions must end with either a JA or a return instructions. When that doesn't happen, program verification will fail.
LLVM does not emit returns or epilogues when a function terminates with a call that never returns, specifically, when the callee halts execution. This PR introduces a pre-emit phase peephole pass that adds a return to a basic block that ends with a call instruction and has no successors. Please, refer to the comment in the code for why I took this approach.