Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes unnecessary casts in datapoints #4193

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Removes unnecessary casts in datapoints #4193

merged 1 commit into from
Dec 20, 2024
+86 −110

Conversation

brooksprumo
Copy link

@brooksprumo brooksprumo commented Dec 20, 2024 •
edited
Loading

Problem

The datapoint!() macro no longer needs to have an explicit cast to the desired type. It's already in the macro.

Summary of Changes

Remove the explicit casts in accounts-db.

@brooksprumo brooksprumo self-assigned this Dec 20, 2024
@brooksprumo brooksprumo marked this pull request as ready for review December 20, 2024 21:28
HaoranYi
HaoranYi approved these changes Dec 20, 2024
View reviewed changes
Copy link

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brooksprumo brooksprumo added the automerge automerge Merge this Pull Request automatically once CI passes label Dec 20, 2024
@mergify mergify bot merged commit 01be984 into anza-xyz:master Dec 20, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaoranYi HaoranYi HaoranYi approved these changes

@dmakarov dmakarov Awaiting requested review from dmakarov

Assignees

@brooksprumo brooksprumo

Labels
automerge automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brooksprumo @HaoranYi