test-validator: Verify program ELFs #4192
Open
+26
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
solana-test-validator
doesn't check whether program ELFs are valid before appending their data to the program data accounts:agave/test-validator/src/lib.rs
Lines 798 to 808 in 3deac72
Summary of changes
Verify program ELFs before adding program data accounts to the genesis configuration.
With this change, the behavior with an invalid program ELF is the same as the
solana program deploy
command. An example output of trying to load an invalid ELF (with mutablestatic
data):Fixes #4191