-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up Partitioned Epoch Rewards feature logic #4186
base: master
Are you sure you want to change the base?
Conversation
The Firedancer team maintains a line-for-line reimplementation of the |
@@ -1899,10 +1906,107 @@ fn test_bank_update_vote_stake_rewards() { | |||
}); | |||
} | |||
|
|||
impl Bank { | |||
#[cfg(test)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file already has a top-level #![cfg(test)]
, is this one also needed?
#[cfg(test)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the actual logic changing in these tests? If yes, wdyt about making those changes in a separate PR? Or are the changes coupled with removing the featurization logic?
0 | ||
}; | ||
|
||
datapoint_warn!( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A question out of the scope of this PR - Are those stats useful to us? Should we port them to partitioned reward code path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup. One of my favorite type of PRs - deleting code!
I have just one question to consider, probably to address in a follow up PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving from SVM
Problem
The feature gate
partitioned_epoch_rewards_superfeature
has been activated on all public clusters, but the gating logic remains.Summary of Changes
bank.rs
, but also the superfeature fix inbank::partitioned_epoch_rewards::sysvar::create_epoch_rewards_sysvar()
Fixes #426