make QUIC tpu QOS parameters configurable #4170
Open
+221
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lijunwangs
commented
Dec 19, 2024
| @@ -54,9 +51,6 @@ use { | |||
| tokio::sync::mpsc::Sender as AsyncSender, | |||
| }; | |||
|
|
|||
| // allow multiple connections for NAT and any open/close overlap | |||
| pub const MAX_QUIC_CONNECTIONS_PER_PEER: usize = 8; | |||
There was a problem hiding this comment.
moved to quic.rs in streamer
lijunwangs
commented
Dec 19, 2024
| @@ -87,14 +87,6 @@ const CONNECTION_CLOSE_REASON_TOO_MANY: &[u8] = b"too_many"; | |||
| const CONNECTION_CLOSE_CODE_INVALID_STREAM: u32 = 5; | |||
| const CONNECTION_CLOSE_REASON_INVALID_STREAM: &[u8] = b"invalid_stream"; | |||
|
|
|||
| /// Limit to 250K PPS | |||
lijunwangs
commented
Dec 19, 2024
| @@ -32,8 +29,19 @@ use { | |||
| tokio::runtime::Runtime, | |||
| }; | |||
|
|
|||
| pub const MAX_STAKED_CONNECTIONS: usize = 2000; | |||
There was a problem hiding this comment.
Rename them to have the DEFAULT_ prefix as they are configurable now
lijunwangs
commented
Dec 20, 2024
| ..Default::default() | ||
| }; | ||
|
|
||
| // Vote shares TPU forward's characteristics, except that we accept 1 connection |
There was a problem hiding this comment.
It should not accept any unstaked connections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Making QUIC TPU QOS parameters configurable so that it is easier to tweak performance and do bench marks.
Summary of Changes
CLI is enabled to pass the following:
--tpu-max-connections-per-peer
--max-tpu-staked-connections
--max-tpu-unstaked-connections
--max-fwd-staked-connections
--max-fwd-unstaked-connections
They are set to hidden unless forced to be shown.
Elevate QuicServerParams configuration to ValidatorTpuConfig as field to configure
tpu, tpu forward and vote quic server parameters.
Move the public default parameters to quic from nonblocking::quic to encapsulate better.
Fixes #