Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIMD-0207: Fix for loading bank from snapshot #4109

Closed
wants to merge 1 commit into from
Closed

SIMD-0207: Fix for loading bank from snapshot #4109

wants to merge 1 commit into from

Conversation

apfitzge
Copy link

Problem

  • cost-tracker is not serialized, so feature was not properly applied on loading from snapshots

Summary of Changes

  • If feature is activated, apply regardless if feature is newly activated
  • bench/test specific opt-out for u64::MAX overrides

Fixes #

@apfitzge apfitzge self-assigned this Dec 13, 2024
brooksprumo
brooksprumo reviewed Dec 13, 2024
View reviewed changes
runtime/src/bank/tests.rs
Comment on lines +8038 to +8039
let slots_per_epoch = bank.epoch_schedule().slots_per_epoch;
let bank = Bank::new_from_parent(Arc::new(bank), &Pubkey::default(), slots_per_epoch);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, there is a helper function, new_from_parent_next_epoch(), that could also be used here.

@apfitzge apfitzge added the noCI Suppress CI on this Pull Request label Dec 13, 2024
@apfitzge apfitzge closed this Dec 13, 2024
@apfitzge
Copy link
Author

Closed in favor of singular #4112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brooksprumo brooksprumo brooksprumo left review comments

Assignees

@apfitzge apfitzge

Labels
noCI Suppress CI on this Pull Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apfitzge @brooksprumo