use new feature gate for cu depletion #3994
Conversation
jstarry
added
feature-gate
|
Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. |
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
|
The Firedancer team maintains a line-for-line reimplementation of the |
There was a problem hiding this comment.
Makes sense to me, but approving on behalf of @anza-xyz/svm. Leaving the final stamp to @Lichtso.
|
@Lichtso - Any concerns or can we merge? |
|
merged on behalf of @jstarry while he's out |
(cherry picked from commit 11467d9) # Conflicts: # programs/bpf_loader/src/lib.rs # programs/sbf/tests/programs.rs # sdk/src/feature_set.rs
(cherry picked from commit 11467d9) # Conflicts: # programs/bpf_loader/src/lib.rs # programs/sbf/tests/programs.rs # sdk/feature-set/src/lib.rs
Problem
Firedancer prefers to have a separate feature gate for each SIMD, so rather than reusing and rekeying the existing replay cost tracker feature, we should create a new feature gate for solana-foundation/solana-improvement-documents#182.
Summary of Changes
Fixes #
Feature Gate Issue: #3993