Skip to content

Conversation

@drichardson-tmp
Copy link
Contributor

Tested by building the wheel and running tests in a python 3.13 environment.

It only needed an upgrade on the pyinstaller dep from ^5.8.0 to ^6.15.0.

@fostimus
Copy link
Contributor

fostimus commented Sep 5, 2025

Hey @drichardson-tmp , thanks for opening a PR! Couple things on our end:

  1. I did the same changes you did, ran into test failures around pydantic
  2. I regenerated the lock file completely, and ran into different test failures, likely from items missing in the dependencies after regenerating the lock file

You can see what I tried here. Unfortunately I don't have any more time today to get this working, but I pushed an update to master to allow the tests to run on PRs to master - if you push up any changes to this branch, the tests will run.

I'll find some time next week to come back to this, but if you can push up a change to make sure the tests pass, we can get this out!

@fostimus fostimus self-assigned this Sep 5, 2025
@drichardson-tmp
Copy link
Contributor Author

Sounds good, I can look into it on my side today, missed this update until now. Thanks for the quick response!

@drichardson-tmp
Copy link
Contributor Author

@fostimus I was able to install locally and run pytest (sorry, not sure how it ran successfully or what I did the first time around, but I saw the same issue).

I had to upgrade pydantic from 2.6 to ^2.8, looking at their release notes it appears there are no breaking changes. I also had to remove the explicit macfsevents from your pyproject.toml. It doesn't appear that is being directly used in your package.

Hopefully it's working consistently on your side as well after this update!

@fostimus
Copy link
Contributor

fostimus commented Sep 9, 2025

@drichardson-tmp tests passed 🎉 thank you for the update, I'll get this published soon

@fostimus fostimus merged commit 2080c55 into anvilco:master Sep 9, 2025
@fostimus
Copy link
Contributor

fostimus commented Sep 9, 2025

@drichardson-tmp published in 5.1.2

https://pypi.org/project/python_anvil/

@drichardson-tmp
Copy link
Contributor Author

Thanks so much @fostimus!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants