-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fullscreen fix #367
Open
DDR0
wants to merge
7
commits into
trunk
Choose a base branch
from
fullscreen-fix
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fullscreen fix #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith other objects were not throwing the FFL exception that they're supposed to throw to allow us to gracefully recover, and were instead just asserting the game. Notably, this was causing a frogatto issue when moth bombers would drop a bomb through other moth bombers, and assert if said bomb overlapped another one as it was spawned.
It needs to be further moved to WindowManager instead of screen_handling, to be beside `bool setWindowSize`.
DDR0
added
Bug
New Rendering Engine Regression
Anura Issue
Graphical / Glitch
Visual abnormalities, corruption, and other visually ugly stuff.
labels
Sep 17, 2023
rkettering
previously approved these changes
Nov 28, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Dec 11, 2023
This has a conflict with one of the other PRs, which went in before this did. Needs manual resolution. |
I have fixed this, at least in the sense that it no longer does nothing. It now enters fullscreen mode well, and then crashes X11 when I exit it. |
rkettering
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Anura Issue
Bug
Graphical / Glitch
Visual abnormalities, corruption, and other visually ugly stuff.
New Rendering Engine Regression
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #368.