-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat: add mark partition #7198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v5
Are you sure you want to change the base?
feat: add mark partition #7198
Conversation
Summary of ChangesHello @moayuisuda, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly extends G2's capabilities by introducing a new Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
这个 PR 引入了新的 hierarchy 标记类型和 DrillDown 交互,用于支持层级结构可视化(如层叠图)。这是一个很棒的功能增强。代码整体结构清晰,但我在 hierarchy.ts 和 drillDown.ts 中发现了一些需要注意的问题,主要涉及数据处理的正确性、性能和 API 的一致性。请查看我的具体评论。
|
这个叫 |
|
那用 partition 吧,Partition |
是这个图吗?https://g2.antv.antgroup.com/examples/general/interval/#bar-marimekko |
|
不如直接叫 flame https://github.com/spiermar/d3-flame-graph?tab=readme-ov-file 类似于词云图,旭日图这些。 |
|
想的是把这个 mark 做宽泛一点,用来承载嵌套数据的场景,不同 encode、coordinate 配置下可以转换为 层叠图、火焰图、旭日图 这些,旭日图这种之前写死 encode 的定制图表就不再透出了 |
Pull Request Test Coverage Report for Build 19496544097Details
💛 - Coveralls |
src/interaction/drillDown.ts
Outdated
| @@ -0,0 +1,265 @@ | |||
| import type { TextStyleProps, DisplayObject } from '@antv/g'; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的 drillDown 能和 treemapDrillDown 合并吗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
下个pr合并吧,试了下改动有点大
src/spec/interaction.ts
Outdated
| }; | ||
| showBreadCrumb?: boolean; | ||
| maxDepth?: number; | ||
| single?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的single和background我看交互里都没用到?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已删
Checklist
npm testpassesDescription of change
支持层叠图

