Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(animate): 修复饼图动画无角度变化时其余属性未更新问题 #5892

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

li1615882553
Copy link
Contributor

@li1615882553 li1615882553 commented Dec 6, 2023

Checklist
  • npm test passes
  • benchmarks are included
  • commit message follows commit guidelines
Description of change

修复饼图更新动画中,如果角度未发生变化,所有属性中只有path做了更新,其余属性未更新

比如颜色更新:
Before :
修改颜色后,因为角度未发生变化,颜色未更新,除非鼠标触发active状态导致角度变化后才更新颜色

Dec-07-2023.11-02-14.mp4

After:
设置了延时更改颜色,颜色可以直接更新

Dec-07-2023.11-18-10.mp4

@github-actions github-actions bot added bugfix and removed bugfix labels Dec 6, 2023
@pearmini
Copy link
Member

pearmini commented Dec 7, 2023

有更详细一点的 PR 描述吗?比如前后对比的视频或者 GIF

@github-actions github-actions bot added bugfix and removed bugfix labels Dec 7, 2023
@li1615882553
Copy link
Contributor Author

有更详细一点的 PR 描述吗?比如前后对比的视频或者 GIF

描述更新了一下

@github-actions github-actions bot added bugfix and removed bugfix labels Dec 7, 2023
Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀🚀🚀

@pearmini pearmini merged commit f6ce41e into antvis:master Dec 7, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants