-
Notifications
You must be signed in to change notification settings - Fork 147
add pseudocode for feature of inter data type and sharding data #813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @Yzing, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request lays crucial groundwork for enhancing the data processing and chart advising capabilities by introducing a robust system for inferring various data shapes (plain, tree, graph, flow) and preparing for data sharding. It involves significant refactoring of data models, adding advanced analytical utilities, and integrating these changes into the existing advising pipeline. The overall goal is to enable more intelligent and context-aware data analysis and visualization recommendations. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant amount of scaffolding and pseudocode for handling various data structures like trees and graphs, and for data sharding. While this is a good step towards the new features, there are several issues in the current implementation, including critical bugs in tests and utility functions, regressions in existing logic, and areas where error handling is missing. The review comments highlight these issues, which should be addressed to ensure the new foundation is solid. Key areas for improvement include fixing the k-means implementation, correcting data shape inference logic, and improving error handling in plugins.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
* feat(ava/advisor): render chart support custom style * fix(ava/advisor): fix auto cr problem --------- Co-authored-by: xueren.dt <[email protected]>
PR includes