-
Notifications
You must be signed in to change notification settings - Fork 418
[Multicast] Add validation to clarify networkPolicyOnly mode is not supported #7362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
418efb5
to
97a09a5
Compare
/test-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the title typo:
networkPolicyMode -> networkPolicyOnly mode
97a09a5
to
42ac183
Compare
8b990b2
to
80c68c5
Compare
docs/multicast-guide.md
Outdated
@@ -9,6 +9,8 @@ Antrea supports multicast traffic in the following scenarios: | |||
the external hosts. | |||
3. External to Pod - Pods can receive the multicast traffic from external | |||
hosts. | |||
4. Multicast is supported in `encap`, `noEncap` and `hybrid` mode, but not in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be a separate paragraph / sentence, not part of this list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You didn't push your changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah... my bad, I thought I did it...
…mode is not supported Signed-off-by: Wenying Dong <[email protected]>
Do we need to merge this PR #7282 first? |
Good catch, I didn't realize you had a PR our for this |
80c68c5
to
bdf7b11
Compare
/test-all |
Add document and validation to clarify that Multicast dos not support networkPolicyOnly mode.