Skip to content

[Multicast] Add validation to clarify networkPolicyOnly mode is not supported #7362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025

Conversation

wenyingd
Copy link
Contributor

Add document and validation to clarify that Multicast dos not support networkPolicyOnly mode.

@wenyingd wenyingd requested a review from luolanzone August 13, 2025 03:46
@wenyingd wenyingd force-pushed the multicast_doc branch 2 times, most recently from 418efb5 to 97a09a5 Compare August 13, 2025 05:27
@wenyingd
Copy link
Contributor Author

/test-all

Copy link
Contributor

@luolanzone luolanzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the title typo:

networkPolicyMode -> networkPolicyOnly mode

@luolanzone luolanzone requested a review from antoninbas August 13, 2025 08:25
@wenyingd wenyingd changed the title [Multicast] Add validation to clarify networkPolicyMode is not supported [Multicast] Add validation to clarify networkPolicyOnly mode is not supported Aug 13, 2025
@wenyingd wenyingd force-pushed the multicast_doc branch 2 times, most recently from 8b990b2 to 80c68c5 Compare August 14, 2025 02:17
@@ -9,6 +9,8 @@ Antrea supports multicast traffic in the following scenarios:
the external hosts.
3. External to Pod - Pods can receive the multicast traffic from external
hosts.
4. Multicast is supported in `encap`, `noEncap` and `hybrid` mode, but not in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be a separate paragraph / sentence, not part of this list

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't push your changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah... my bad, I thought I did it...

@hongliangl
Copy link
Contributor

Do we need to merge this PR #7282 first?

@antoninbas
Copy link
Contributor

Do we need to merge this PR #7282 first?

Good catch, I didn't realize you had a PR our for this

@antoninbas
Copy link
Contributor

/test-all

@luolanzone luolanzone merged commit 80a0185 into antrea-io:main Aug 18, 2025
59 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants