Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "ipv4-only" and "ipv6-only" flags for "antctl get bgppeers" #6755

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add "ipv4-only" and "ipv6-only" flags for "antctl get bgppeers" #6755

wants to merge 1 commit into from
+240 −64

Conversation

Atish-iaf
Copy link
Contributor

No description provided.

@Atish-iaf Atish-iaf added area/component/antctl Issues or PRs releated to the command line interface component area/transit/bgp Issues or PRs related to BGP support. labels Oct 18, 2024
@Atish-iaf Atish-iaf marked this pull request as ready for review October 18, 2024 10:17
antoninbas
antoninbas reviewed Oct 18, 2024
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically the same 3 comments I had for the bgproutes PR also apply here

pkg/agent/apiserver/handlers/bgppeer/handler.go Outdated Show resolved Hide resolved
@Atish-iaf Atish-iaf force-pushed the add-flags-in-antctl-get-bgppeers branch from 2715024 to 17ab0c9 Compare October 19, 2024 03:53
@rajnkamr rajnkamr added this to the Antrea v2.2 release milestone Oct 21, 2024
@Atish-iaf Atish-iaf force-pushed the add-flags-in-antctl-get-bgppeers branch from 17ab0c9 to 85205a6 Compare October 21, 2024 07:27
@rajnkamr rajnkamr added kind/documentation Categorizes issue or PR as related to a documentation. action/release-note Indicates a PR that should be included in release notes. labels Oct 21, 2024
@Atish-iaf Atish-iaf removed the kind/documentation Categorizes issue or PR as related to a documentation. label Oct 21, 2024
@Atish-iaf Atish-iaf force-pushed the add-flags-in-antctl-get-bgppeers branch 3 times, most recently from 868132e to aa383f0 Compare October 22, 2024 06:46
@Atish-iaf Atish-iaf changed the title Add "ipv6" and "ipv4" flags for "antctl get bgppeers" Add "ipv4-only" and "ipv6-only" flags for "antctl get bgppeers" Oct 22, 2024
@Atish-iaf
Copy link
Contributor Author

/test-all

@Atish-iaf Atish-iaf force-pushed the add-flags-in-antctl-get-bgppeers branch from aa383f0 to 0885bcd Compare October 22, 2024 17:45
antoninbas
antoninbas reviewed Oct 22, 2024
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small comment, otherwise lgtm

pkg/agent/controller/bgp/controller_test.go Outdated Show resolved Hide resolved
@Atish-iaf Atish-iaf force-pushed the add-flags-in-antctl-get-bgppeers branch from 0885bcd to 8d4e3df Compare October 22, 2024 19:02
antoninbas
antoninbas previously approved these changes Oct 22, 2024
View reviewed changes
@Atish-iaf
Copy link
Contributor Author

/test-all

tnqn
tnqn previously approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas
Copy link
Contributor

@Atish-iaf please resolve the conflict

@Atish-iaf Atish-iaf dismissed stale reviews from tnqn and antoninbas via 21aa2f2 October 23, 2024 22:48
@Atish-iaf Atish-iaf force-pushed the add-flags-in-antctl-get-bgppeers branch from 8d4e3df to 21aa2f2 Compare October 23, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoninbas antoninbas antoninbas left review comments

@tnqn tnqn tnqn left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
action/release-note Indicates a PR that should be included in release notes. area/component/antctl Issues or PRs releated to the command line interface component area/transit/bgp Issues or PRs related to BGP support.
Projects
None yet
Milestone
Antrea v2.2 release
Development

Successfully merging this pull request may close these issues.
4 participants
@Atish-iaf @antoninbas @tnqn @rajnkamr