Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pin typeguard<4.3.0 #300

Merged
merged 1 commit into from
Sep 15, 2024
Merged

fix: Pin typeguard<4.3.0 #300

merged 1 commit into from
Sep 15, 2024

Conversation

antonagestam
Copy link
Owner

typeguard 4.3.0 introduced refined support for protocol type checking, unfortunately this breaks some existing usages in phantom-types, which in turn breaks sized types. As there's seemingly no trivial way to work around the issue, this commit pins typeguard at 4.3.0 until there is a fix upstream.

#299

typeguard 4.3.0 introduced refined support for protocol type checking,
unfortunately this breaks some existing usages in phantom-types, which
in turn breaks sized types. As there's seemingly no trivial way to work
around the issue, this commit pins typeguard at 4.3.0 until there is a
fix upstream.

#299
@antonagestam antonagestam enabled auto-merge (squash) September 15, 2024 16:04
Copy link

codecov bot commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.91%. Comparing base (0b2fcaa) to head (5314258).
Report is 34 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #300   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files          27       27           
  Lines        1017     1018    +1     
  Branches      160      160           
=======================================
+ Hits         1006     1007    +1     
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antonagestam antonagestam merged commit ebd5f66 into main Sep 15, 2024
11 checks passed
@antonagestam antonagestam deleted the fix/pin-typeguard branch September 15, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant