Replace assert with proper error handling in tool execution loop#70
Open
hobostay wants to merge 1 commit into
Open
Replace assert with proper error handling in tool execution loop#70hobostay wants to merge 1 commit into
hobostay wants to merge 1 commit into
Conversation
`assert last_error is not None` was used as a runtime guard, but asserts are stripped when Python runs with -O (optimized mode). If the invariant were ever violated under -O, `last_error[0]` would raise an opaque TypeError instead of a meaningful error. Replace with an explicit if-check that raises ToolExecutionError with a clear diagnostic message if last_error is unexpectedly None. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assert last_error is not Nonewas used as a runtime guard in the tool execution error pathassertstatements when run with-O(optimized mode), which some deployments use-O,last_error[0]would raise an opaqueTypeErrorinstead of a meaningful errorReplace with an explicit if-check that raises
ToolExecutionErrorwith a clear diagnostic message.Test plan
python -Ois correct🤖 Generated with Claude Code