Fix unhandled JSONDecodeError in AnthropicClient tool call parsing#69
Open
hobostay wants to merge 1 commit into
Open
Fix unhandled JSONDecodeError in AnthropicClient tool call parsing#69hobostay wants to merge 1 commit into
hobostay wants to merge 1 commit into
Conversation
`json.loads(args)` in `_convert_messages` was called without a try/except. If the upstream system passes malformed JSON in tool call arguments, this raises an unhandled `json.JSONDecodeError` that propagates as an uncaught exception, crashing the inference loop with an unhelpful traceback instead of a recoverable error. Wrap in try/except and fall back to empty dict on parse failure, consistent with how LlamafileClient handles the same case. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
json.loads(args)in_convert_messageswas called without a try/except when parsing tool call argumentsjson.JSONDecodeError, crashing the inference loop with an unhelpful tracebackImpact
Test plan
🤖 Generated with Claude Code