Addition of Multi-Agent PDDL to ANTLR v4 #4034

refracc · 2024-03-29T15:23:16Z

Still parses standard PDDL files, as well as new MA-PDDL files (which are almost up to the full specification of Kovacs, 2012).

kaby76 · 2024-03-29T21:53:40Z

pddl/Pddl.g4

-    : (domain | problem) EOF
-    ;
+
+pddlDoc : domain | problem;


All Antlr4 grammars need an EOF-terminated start rule. Add EOF back in so the tester can find the rule.

kaby76 · 2024-03-29T22:35:51Z

There is not a single test file for this grammar. I went to http://www.plg.inf.uc3m.es/ipc2011-deterministic/Resources , downloaded the .bz2 file (http://www.plg.inf.uc3m.es/ipc2011-deterministic/attachments/Resources/ipc2008-no-cybersec.tar.bz2), extracted the demos, and tried every single .pddl file. Some parsed (about 30 files in seq-opt/pegsol-strips/p[0-9][0-9].pddl) but most did not.

It's time to try to get this grammar up to a basic level of usability that people expect. Currently, I'm not sure how usable it is.

kaby76 · 2024-03-29T22:41:31Z

pddl/Pddl.g4

-// $antlr-format alignTrailingComments true, columnLimit 150, minEmptyLines 1, maxEmptyLinesToKeep 1, reflowComments false, useTab false
-// $antlr-format allowShortRulesOnASingleLine false, allowShortBlocksOnASingleLine true, alignSemicolons hanging, alignColons hanging
+ // $antlr-format alignTrailingComments true, columnLimit 150, minEmptyLines 1, maxEmptyLinesToKeep 1, reflowComments false, useTab false
+ // $antlr-format allowShortRulesOnASingleLine false, allowShortBlocksOnASingleLine true, alignSemicolons hanging, alignColons hanging


I'm not sure why these formatting rules were changed. Please go to https://github.com/mike-lischke/antlr-format/blob/main/cli/ReadMe.md and install the antlr-formatter. Then, reformat this grammar antlr-format *.g4.

The formatting rules weren't changed - they just moved down ~15 lines?

Apologies for not formatting, I've now formatted the file.

kaby76 · 2024-03-29T22:52:10Z

If it's not a problem, could you "fast forward" the branch for this PR with the current "master" branch in https://github.com/antlr/grammars-v4.git ?? It'll help me see how my new "perf" scripts handle your PR. Thanks!

PR FF

refracc · 2024-04-03T15:26:25Z

There is not a single test file for this grammar. I went to http://www.plg.inf.uc3m.es/ipc2011-deterministic/Resources , downloaded the .bz2 file (http://www.plg.inf.uc3m.es/ipc2011-deterministic/attachments/Resources/ipc2008-no-cybersec.tar.bz2), extracted the demos, and tried every single .pddl file. Some parsed (about 30 files in seq-opt/pegsol-strips/p[0-9][0-9].pddl) but most did not.

It's time to try to get this grammar up to a basic level of usability that people expect. Currently, I'm not sure how usable it is.

Considering that there were no prior instances provided alongside the PDDL parser or its application to domains (i.e., their specification), I am perplexed as to why - particularly in light of the lack of examples initially presented in the folder - this seems to have become an apparent issue. Could you kindly clarify why the previous author was not prompted to include examples, or why none were included here initially?

I have taken the liberty of incorporating examples of the contrived "single-agent" problems, along with the contrived "multi-agent" domains that this file can parse, and they do align with some aspects of the Kovacs implementation. As articulated in my comment within the parser file itself, further refinement is necessary to bring it up to par with this standard. Nevertheless, this should serve as a commendable starting point towards achieving that objective.

Furthermore, the branch has been fast-forwarded to accommodate your new scripts.

kaby76 · 2024-04-03T19:56:36Z

Could you kindly clarify why the previous author was not prompted to include examples, or why none were included here initially?

@teverett added the grammar 9 years ago, probably as a task of translating the grammar from Antlr3 into Antlr4. But, he didn't have any sample input. I added the desc.xml last year in order to support testing of all targets, but again, I punted on finding any tests because I really don't have expertise in the language.

Nevertheless, this should serve as a commendable starting point towards achieving that objective.

Ty, Ty, Ty!!

kaby76 · 2024-04-05T12:22:24Z

pddl/MultiAgentPDDL.g4

+    ;
+
+objectDeclaration
+    : objectName '-' objectType


Please change to objectName+. See http://www.plg.inf.uc3m.es/ipc2011-deterministic/attachments/Resources/kovacs-pddl-3.1-2011.pdf , specifically the rule <function typed list (x)> ::= x+ - <function type> <function typed list(x)>. Notice the "+" for "x", where it is used in rule <object declaration> ::= (:objects <typed list (name)>). Some of the tests don't parse without this.

A single character escaped me - apologies. Resolved!

kaby76 · 2024-04-05T12:24:10Z

Please change desc.xml to this so we can test both grammars.

<?xml version="1.0" encoding="UTF-8" ?>
<desc xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../_scripts/desc.xsd">
   <targets>CSharp;Dart;Go;Java;JavaScript;PHP;Python3;TypeScript;Antlr4ng</targets>
   <test>
      <name>multi</name>
      <grammar-files>MultiAgentPDDL.g4</grammar-files>
      <inputs>multi-agent-examples/**/*.pddl</inputs>
   </test>
   <test>
      <name>single</name>
      <grammar-files>SingleAgentPDDL.g4</grammar-files>
      <inputs>single-agent-examples/**/*.pddl</inputs>
   </test>
</desc>

…are correct)

refracc · 2024-04-05T12:38:52Z

Please change desc.xml to this so we can test both grammars.

<?xml version="1.0" encoding="UTF-8" ?>
<desc xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../_scripts/desc.xsd">
   <targets>CSharp;Dart;Go;Java;JavaScript;PHP;Python3;TypeScript;Antlr4ng</targets>
   <test>
      <name>multi</name>
      <grammar-files>MultiAgentPDDL.g4</grammar-files>
      <inputs>multi-agent-examples/**/*.pddl</inputs>
   </test>
   <test>
      <name>single</name>
      <grammar-files>SingleAgentPDDL.g4</grammar-files>
      <inputs>single-agent-examples/**/*.pddl</inputs>
   </test>
</desc>

All files should now parse under the one grammar file. See my latest commit. I've updated the test in desc.xml to reflect that.

kaby76 · 2024-04-05T13:12:33Z

Yes, better.

Looks like still a few problems.

$ trgen -t CSharp
C:\msys64\home\Kenne\issues\g4-4034\g4-4034\pddl
CSharp  Pddl.g4 success 0.0484755
Rendering template file from CSharp/Other.csproj to ./Generated-CSharp-Pddl/Other.csproj
Rendering template file from CSharp/st.build.ps1 to ./Generated-CSharp-Pddl/st.build.ps1
Rendering template file from CSharp/st.build.sh to ./Generated-CSharp-Pddl/st.build.sh
Rendering template file from CSharp/st.clean.ps1 to ./Generated-CSharp-Pddl/st.clean.ps1
Rendering template file from CSharp/st.clean.sh to ./Generated-CSharp-Pddl/st.clean.sh
Rendering template file from CSharp/st.Encodings.cs to ./Generated-CSharp-Pddl/st.Encodings.cs
Rendering template file from CSharp/st.ErrorListener.cs to ./Generated-CSharp-Pddl/st.ErrorListener.cs
Rendering template file from CSharp/st.makefile to ./Generated-CSharp-Pddl/st.makefile
Rendering template file from CSharp/st.perf.sh to ./Generated-CSharp-Pddl/st.perf.sh
Rendering template file from CSharp/st.run.ps1 to ./Generated-CSharp-Pddl/st.run.ps1
Rendering template file from CSharp/st.run.sh to ./Generated-CSharp-Pddl/st.run.sh
Rendering template file from CSharp/st.test-cover.sh to ./Generated-CSharp-Pddl/st.test-cover.sh
Rendering template file from CSharp/st.Test.cs to ./Generated-CSharp-Pddl/st.Test.cs
Rendering template file from CSharp/st.test.ps1 to ./Generated-CSharp-Pddl/st.test.ps1
Rendering template file from CSharp/st.test.sh to ./Generated-CSharp-Pddl/st.test.sh
Rendering template file from CSharp/Test.csproj.st to ./Generated-CSharp-Pddl/Test.csproj.st
Copying source file from C:/msys64/home/Kenne/issues/g4-4034/g4-4034/pddl/README.md to ./Generated-CSharp-Pddl/README.md
Copying source file from C:/msys64/home/Kenne/issues/g4-4034/g4-4034/pddl/Pddl.g4 to ./Generated-CSharp-Pddl/Pddl.g4
Copying source file from C:/msys64/home/Kenne/issues/g4-4034/g4-4034/pddl/desc.xml to ./Generated-CSharp-Pddl/desc.xml
04/05-09:11:42 ~/issues/g4-4034/g4-4034/pddl
$ make
mingw32-make: *** No targets specified and no makefile found.  Stop.
04/05-09:11:43 ~/issues/g4-4034/g4-4034/pddl
$ cd Generated-CSharp-Pddl/
04/05-09:11:46 ~/issues/g4-4034/g4-4034/pddl/Generated-CSharp-Pddl
$ make
bash build.sh
  Determining projects to restore...
  Restored C:\msys64\home\Kenne\issues\g4-4034\g4-4034\pddl\Generated-CSharp-Pddl\Test.csproj (in 337 ms).
MSBuild version 17.9.4+90725d08d for .NET
  Determining projects to restore...
  All projects are up-to-date for restore.
  Test -> C:\msys64\home\Kenne\issues\g4-4034\g4-4034\pddl\Generated-CSharp-Pddl\bin\Debug\net8.0\Test.dll

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:04.60
04/05-09:11:53 ~/issues/g4-4034/g4-4034/pddl/Generated-CSharp-Pddl
$ make test
bash test.sh
New errors in output.
examples/multi-agent/wireless/domain.pddl.errors
line 74:15 mismatched input '?sender' expecting {'(', 'at', 'over', NAME, NUMBER}
examples/single-agent/barman-sequential-satisficing/domain.pddl.errors
line 2:33 extraneous input ':action' expecting {')', REQUIRE_KEY}
examples/single-agent/depots-strips-hand-coded/instance-1.pddl.errors
line 28:15 extraneous input '-' expecting {')', 'at', 'over', NAME}
line 30:1 no viable alternative at input '(:predicates'
line 31:14 mismatched input 'on' expecting ':goal'
line 32:13 mismatched input '(' expecting <EOF>
examples/single-agent/openstacks-temporal-satisficing-adl-numeric-fluents/domain.pddl.errors
line 2:46 token recognition error at: ':nu'
line 2:49 extraneous input 'meric-fluents' expecting {')', REQUIRE_KEY}
examples/single-agent/openstacks-temporal-satisficing-adl-numeric-fluents/instance-1.pddl.errors
line 41:19 no viable alternative at input '(total-time'
line 43:0 extraneous input ')' expecting <EOF>
examples/single-agent/openstacks-temporal-satisficing-adl-numeric-fluents/instance-10.pddl.errors
line 77:19 no viable alternative at input '(total-time'
line 79:0 extraneous input ')' expecting <EOF>
examples/single-agent/openstacks-temporal-satisficing-adl-numeric-fluents/instance-20.pddl.errors
line 117:19 no viable alternative at input '(total-time'
line 119:0 extraneous input ')' expecting <EOF>
examples/single-agent/openstacks-temporal-satisficing-adl-numeric-fluents/instance-30.pddl.errors
line 157:19 no viable alternative at input '(total-time'
line 159:0 extraneous input ')' expecting <EOF>
examples/single-agent/road-traffic-accident-management-temporal-satisficing/instance-1.pddl.errors
line 395:19 no viable alternative at input '(total-time'
line 396:0 extraneous input ')' expecting <EOF>
examples/single-agent/road-traffic-accident-management-temporal-satisficing/instance-10.pddl.errors
line 446:19 no viable alternative at input '(total-time'
line 447:0 extraneous input ')' expecting <EOF>
examples/single-agent/road-traffic-accident-management-temporal-satisficing/instance-20.pddl.errors
line 697:19 no viable alternative at input '(total-time'
line 698:0 extraneous input ')' expecting <EOF>
examples/single-agent/sokoban-temporal-satisficing/instance-1.pddl.errors
line 344:21 no viable alternative at input '(total-time'
line 345:0 extraneous input ')' expecting <EOF>
examples/single-agent/sokoban-temporal-satisficing/instance-10.pddl.errors
line 383:21 no viable alternative at input '(total-time'
line 384:0 extraneous input ')' expecting <EOF>
examples/single-agent/sokoban-temporal-satisficing/instance-20.pddl.errors
line 375:21 no viable alternative at input '(total-time'
line 376:0 extraneous input ')' expecting <EOF>
examples/single-agent/transport-sequential-satisficing/domain.pddl.errors
line 5:25 extraneous input ':action' expecting {')', REQUIRE_KEY}
examples/single-agent/trucks-preferences-simple/instance-1.pddl.errors
line 66:2 no viable alternative at input '(preference'
line 68:1 missing ')' at '('
examples/single-agent/trucks-preferences-simple/instance-10.pddl.errors
line 410:2 no viable alternative at input '(preference'
line 412:1 missing ')' at '('
examples/single-agent/trucks-preferences-simple/instance-20.pddl.errors
line 993:2 no viable alternative at input '(preference'
line 994:1 missing ')' at '('
Test failed.
mingw32-make: *** [makefile:8: test] Error 1
04/05-09:12:11 ~/issues/g4-4034/g4-4034/pddl/Generated-CSharp-Pddl
$

…are correct)

$refracc$

refracc added 2 commits March 29, 2024 15:16

$@refracc$

add ma-pddl

05cd15e

$@refracc$

update script

dd4c749

kaby76 reviewed Mar 29, 2024

View reviewed changes

refracc and others added 9 commits April 3, 2024 14:15

$@refracc$

Merge pull request #1 from antlr/master

97d941e

PR FF

$@refracc$

Merge remote-tracking branch 'origin/master' into mapddl

f8e92e3

$@refracc$

format Pddl.g4

92a12a0

$@refracc$

Add multi-agent examples

9df768b

$@refracc$

remove unnecessary text files

00e1ef3

$@refracc$

Add example domains

d4eba75

$@refracc$

remove parse trees

fb4e1c4

$@refracc$

update comment in pddl parser file

9c04ca0

$@refracc$

re-format for sanity

e0f8d00

$@refracc$

remove auxilliary PDDL files from testing parser

0d3a0ac

$@refracc$ refracc requested a review from kaby76 April 3, 2024 15:49

refracc added 2 commits April 4, 2024 14:56

$@refracc$

Separate into single agent and multi-agent acceptable grammars

6071d82

$@refracc$

re-format files

8e2fa28

kaby76 reviewed Apr 5, 2024

View reviewed changes

$@refracc$

PDDL updated to work with one file instead of two (assuming my tests …

4006f66

…are correct)

teverett added the pddl label Apr 5, 2024

refracc and others added 3 commits April 30, 2024 14:21

$@refracc$

Merge branch 'antlr:master' into master

8d78b0a

$@refracc$

add ma-pddl

965315c

$@refracc$

update script

0eef201

refracc added 15 commits April 30, 2024 14:22

$@refracc$

format Pddl.g4

e0157c2

$@refracc$

Add multi-agent examples

9bc280c

$@refracc$

remove unnecessary text files

6748d0e

$@refracc$

Add example domains

9879619

$@refracc$

remove parse trees

8fc3609

$@refracc$

update comment in pddl parser file

faee6a6

$@refracc$

re-format for sanity

f38e424

$@refracc$

remove auxilliary PDDL files from testing parser

6c3c9ea

$@refracc$

Separate into single agent and multi-agent acceptable grammars

cadd6ef

$@refracc$

re-format files

0c8c24e

$@refracc$

PDDL updated to work with one file instead of two (assuming my tests …

e29842e

…are correct)

$@refracc$

Merge branch 'mapddl' of github.com:refracc/grammars-v4 into mapddl

a818cf5

$@refracc$

resolved errors w/ total-time (should've been total-cost)

8a7898a

$@refracc$

move files into parent dir

64e55aa

$@refracc$

fix wireless domain

079e61a

$@refracc$ refracc requested a review from kaby76 April 30, 2024 14:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Addition of Multi-Agent PDDL to ANTLR v4 #4034

Addition of Multi-Agent PDDL to ANTLR v4 #4034

$@refracc$ refracc commented Mar 29, 2024

kaby76 Mar 29, 2024

$@refracc$ refracc Apr 3, 2024

kaby76 commented Mar 29, 2024 •

edited

Loading

kaby76 Mar 29, 2024

$@refracc$ refracc Apr 3, 2024

kaby76 commented Mar 29, 2024

refracc commented Apr 3, 2024

kaby76 commented Apr 3, 2024

kaby76 Apr 5, 2024

$@refracc$ refracc Apr 5, 2024

kaby76 commented Apr 5, 2024

refracc commented Apr 5, 2024

kaby76 commented Apr 5, 2024

Addition of Multi-Agent PDDL to ANTLR v4 #4034

Are you sure you want to change the base?

Addition of Multi-Agent PDDL to ANTLR v4 #4034

Conversation

refracc commented Mar 29, 2024

kaby76 Mar 29, 2024

Choose a reason for hiding this comment

refracc Apr 3, 2024

Choose a reason for hiding this comment

kaby76 commented Mar 29, 2024 • edited Loading

kaby76 Mar 29, 2024

Choose a reason for hiding this comment

refracc Apr 3, 2024

Choose a reason for hiding this comment

kaby76 commented Mar 29, 2024

refracc commented Apr 3, 2024

kaby76 commented Apr 3, 2024

kaby76 Apr 5, 2024

Choose a reason for hiding this comment

refracc Apr 5, 2024

Choose a reason for hiding this comment

kaby76 commented Apr 5, 2024

refracc commented Apr 5, 2024

kaby76 commented Apr 5, 2024

$@refracc$ refracc commented Mar 29, 2024

$@refracc$ refracc Apr 3, 2024

kaby76 commented Mar 29, 2024 •

edited

Loading

$@refracc$ refracc Apr 3, 2024

$@refracc$ refracc Apr 5, 2024