-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Kotlin core for java runtime #40
Use Kotlin core for java runtime #40
Conversation
Signed-off-by: Eric Vergnaud <[email protected]>
Signed-off-by: Eric Vergnaud <[email protected]> # Conflicts: # runtime-testsuite/test/org/antlr/v5/test/runtime/java/api/TestExpectedTokens.java # runtime/Java/src/main/java/org/antlr/v5/runtime/atn/ATN.java # runtime/Java/src/main/java/org/antlr/v5/runtime/atn/ATNDeserializer.java # runtime/Java/src/main/java/org/antlr/v5/runtime/atn/ATNState.java # runtime/Java/src/main/java/org/antlr/v5/runtime/atn/CodePointTransitions.java # tool/src/org/antlr/v5/automata/ATNOptimizer.java # tool/src/org/antlr/v5/automata/ATNVisitor.java # tool/src/org/antlr/v5/automata/ParserATNFactory.java # tool/src/org/antlr/v5/automata/TailEpsilonRemover.java
Quickly skimmed through the changes. Since I suppose at some point ANTLR 5 will get rid of the Java runtime, I'd say it's all good as long as tests pass. Just a couple of commits I'd revisit: e8ae531, 9c125e4 |
Signed-off-by: Eric Vergnaud <[email protected]>
Signed-off-by: Eric Vergnaud <[email protected]>
Signed-off-by: Eric Vergnaud <[email protected]>
Signed-off-by: Eric Vergnaud <[email protected]>
Signed-off-by: Eric Vergnaud <[email protected]>
Signed-off-by: Eric Vergnaud <[email protected]>
Actually the nullables are required to make the tests pass. That said your suggestions are welcome and we might change that in favor of your proposed strategy. I'd be in favor of doing that in a separate PR such that we know what we're breaking and we can measure the impact on performance ? See #44 |
@KvanTTT given the broad scope of this PR, I had to merge your latest changes from dev into this branch. It wasn't seamless, so you might want to double-check the affected files. |
# Conflicts: # pom.xml
@KvanTTT any comments ? |
No, I'm on vacation. Feel free to merge without my approval. |
This is far from being mergeable (many tests fail) but I thought it might be worth starting to look at the changes and provide comments.