fix: Cpp: correct static library linking depending on the host OS #4462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The static linking did not succeed on Windows due to the name of the static library on Windows, libantlr4-runtime-static.a. The name libantlr4-runtime.a works on other OSs with no problem. Signed-off-by: Osama Ahmad <[email protected]>
OsamaAhmad00
force-pushed
the
cpp-static-lib-fix
branch
from
001b41e
to
e76c811
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The static linking did not succeed on Windows due to the name of the static library on Windows, libantlr4-runtime-static.a. The name libantlr4-runtime.a works on other OSs with no problem.