Improved mypy type-checking for generated Python3 files. #4407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. Thanks for this. |
|
Are you referring to the import statements being duplicated? Yes, those
were generated by monkeytype. Are there others? That might be a merge issue
on my side.
What's DCO? And I'm currently fixing the CI/CD failure. It appears that
runtime files need to be able to stand more independently than I tested
them.
…On Tue, Sep 5, 2023 at 2:21 AM ericvergnaud ***@***.***> wrote:
Hi. Thanks for this.
I'm seeing a lot of duplicate code in this PR, I guess this was machine
generated ?
It's not currently mergeable, missing DCO, and the python 3 build now
fails...
—
Reply to this email directly, view it on GitHub
<#4407 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE4SNBUPP346L7UGMD4BMKTXY3VJLANCNFSM6AAAAAA4KSBFEY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Yes I am referring to the duplicate imports |
|
This branch appears incomplete. Separation from private branch not done correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Antlr4's generated code for Python3 target had some misuse of slots. All the base objects were not using slots so derived objects from them didn't correctly enforce slots. slots were added to base objects. Additionally, a number of forward declarations were made as class_name = None, this causes issues with mypy when checking code. Imports and other forward declarations were added to correct this. Furthermore, return types and argument types were added to functions within runtime to contribute to mypy type checking. Emitted code was verified by generating a parser for java8 using python 3.11