Make test suite deterministic. #195
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid using java.util.HashSet, since iteration order in the hash set is dependent on the exact size of the hash set, bucket organization, etc. Use java.util.LinkedHashSet/LinkedHashMap so that iteration order is always repeatable.
sharwell
approved these changes
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid using
java.util.HashSet/java.util.HashMap, since iteration order in the hash set (even if the keys'hashCodemethods are deterministic) is dependent on the exact size of the hash set, bucket organization, etc. This changes for different versions of the JDK, causing tests to have repeatable false failures when run on (eg) openjdk 1.8 (it appears the test suite was written against JDK 5/6).Use
java.util.LinkedHashSet/LinkedHashMapso that the iteration order is always repeatable (and the tests always pass). (Define a few missinghashCodemethods while we're at it, although using LinkedHashSet means that isn't necessary in order to get repeatable iteration order.)