-
Notifications
You must be signed in to change notification settings - Fork 233
refactor: improve filters UX #940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@Udit-takkar is attempting to deploy a commit to the Antiwork Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThis PR makes UI-only presentation changes: removes center justification in ConversationFilters, replaces a check icon with a native checkbox in CustomerFilter (preserving selection logic), and changes dropdown menu items’ cursor to pointer. No public APIs or data flows were modified. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
components/ui/dropdown-menu.tsx (1)
87-91
: Pointer cursor on menu items: good UX improvement; consider aligning SubTrigger tooThe cursor-pointer updates on Item, CheckboxItem, and RadioItem align with user expectations for clickable rows.
For consistency, DropdownMenuSubTrigger (Line 27) still uses cursor-default. Consider switching it to cursor-pointer as well so all clickable rows share the same hover affordance.
Example update outside the changed hunk:
className={cn( "flex cursor-pointer select-none items-center rounded-sm px-2 py-1.5 text-sm outline-hidden focus:bg-accent data-[state=open]:bg-accent", inset && "pl-8", className, )}Also applies to: 106-109, 132-135
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
app/(dashboard)/[category]/list/conversationFilters.tsx
(1 hunks)app/(dashboard)/[category]/list/filters/customerFilter.tsx
(2 hunks)components/ui/dropdown-menu.tsx
(3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.tsx
📄 CodeRabbit Inference Engine (.cursorrules)
Name component files in lowerCamelCase, e.g. conversationList.tsx
Files:
app/(dashboard)/[category]/list/conversationFilters.tsx
components/ui/dropdown-menu.tsx
app/(dashboard)/[category]/list/filters/customerFilter.tsx
🧠 Learnings (1)
📚 Learning: 2025-05-14T01:59:31.051Z
Learnt from: MJomaa
PR: antiwork/helper#351
File: app/(marketing)/help/page.tsx:49-50
Timestamp: 2025-05-14T01:59:31.051Z
Learning: In Next.js applications using Tailwind and shadcn/ui, apply button styles directly to Link components using `className={cn(buttonVariants(...))}` rather than nesting Button components inside Links with passHref. This pattern reduces component nesting and is the preferred approach for creating button-styled links.
Applied to files:
components/ui/dropdown-menu.tsx
🔇 Additional comments (1)
app/(dashboard)/[category]/list/conversationFilters.tsx (1)
126-126
: Alignment change LGTMRemoving justify-center matches the PR objective and will left-align the filter row content. No logic changes introduced.
Related to #930
Before:-
Screen.Recording.2025-08-16.at.9.42.59.PM.mov
After:-
Cursor becomes pointer when you hover over dropdown items as items are clickable
Added checkbox instead of whitespace which also helps indicate user that multiple items can be selected for filtering
Screen.Recording.2025-08-16.at.9.58.32.PM.mov
Summary by CodeRabbit