Fix 'comparison is always false' warning on ARM/unsigned char platforms #244
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Fix type limit warning in linenoiseEditFeed on ARM builds
Description
I encountered a compilation warning when cross-compiling for AArch64 (ARMv8) using GCC with
-Wextraenabled:Reason:
On ARM platforms, the
chartype isunsignedby default (0 to 255). Therefore, the checkc < 0never evaluates to true, effectively ignoring error codes returned bycompleteLine().Fix:
Explicitly cast
cto(signed char)in the conditional check. This ensures that negative return values are correctly identified regardless of the platform's defaultcharsignedness.Verification