simplify handling of input escape codes & support ctrl+arrows #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this: 1. prevents unknown escape sequences from leaking over as real input in some situations 2. makes it easier to handle longer escape sequences in the future
yhirose's patch didn't make linenoiseEditDeletePrevWord() use the encoding abstractions, so i'm being consistent here. it works with utf8 anyways furthermore, this makes it easier to cherrypick this onto a separate branch and send as a PR upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESC [codes always end with a char in0x40-0x7E. Using that lets me (subjectively) simplify the handling of longer escape codes and prevent unrecognized codes from being handled as user input.Also, since this makes adding support for new escape codes easier, I took the chance to implement Ctrl+arrows for moving between words ala readline.