fix: avoid 'success' as error text when errors list is empty#1039
Open
ashishpatel26 wants to merge 1 commit into
Open
fix: avoid 'success' as error text when errors list is empty#1039ashishpatel26 wants to merge 1 commit into
ashishpatel26 wants to merge 1 commit into
Conversation
…ics#1031) When the CLI emits is_error=True with an empty errors[] array and subtype='success', the SDK was producing the misleading message 'Claude Code returned an error result: success'. The fallback now skips 'success' as a subtype label and uses 'unknown error' instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #1031
When the CLI emits
is_error=Truewith an emptyerrors[]array andsubtype="success", the SDK was producing the misleading message:The fallback logic now skips
"success"as an error label and uses"unknown error"instead.Changes Made
src/claude_agent_sdk/_internal/query.py: fix fallback in_read_messagessosubtype="success"is never used as the error descriptiontests/test_query.py: add regression tests covering emptyerrors[]withsubtype="success", meaningful subtype, non-empty errors list, and the no-error (success) caseTesting
tests/test_query.pypython -m pytest tests/test_query.py -x -q→ 41 passed)Related Issue
Closes #1031