Skip to content

fix(tools): raise a graceful ToolError when a memory file is not valid UTF-8 #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WalkingDreams798 wants to merge 1 commit into
base: main
Choose a base branch
from
+26 −0
Open

fix(tools): raise a graceful ToolError when a memory file is not valid UTF-8 #1693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/anthropic/lib/tools/_beta_builtin_memory_tool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,8 @@ def _read_file_content(full_path: Path, memory_path: str) -> str:
raise ToolError(
f"The file {memory_path} no longer exists (may have been deleted or renamed concurrently)."
) from err
except UnicodeDecodeError as err:
raise ToolError(f"The file {memory_path} is not a valid UTF-8 text file and cannot be read as memory.") from err


def _format_file_size(bytes_size: int) -> str:
Expand Down Expand Up @@ -620,6 +622,8 @@ async def _async_read_file_content(full_path: AsyncPath, memory_path: str) -> st
raise ToolError(
f"The file {memory_path} no longer exists (may have been deleted or renamed concurrently)."
) from err
except UnicodeDecodeError as err:
raise ToolError(f"The file {memory_path} is not a valid UTF-8 text file and cannot be read as memory.") from err


class BetaAsyncLocalFilesystemMemoryTool(BetaAsyncAbstractMemoryTool):
Expand Down
22 changes: 22 additions & 0 deletions tests/lib/tools/memory_tools/test_filesystem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,16 @@ def test_view_error_for_non_existent_file(self, sync_local_filesystem_tool: Beta
BetaMemoryTool20250818ViewCommand(command="view", path="/memories/nonexistent.txt")
)

def test_view_error_for_non_utf8_file(self, sync_local_filesystem_tool: BetaLocalFilesystemMemoryTool) -> None:
memory_root = sync_local_filesystem_tool.memory_root
memory_root.mkdir(parents=True, exist_ok=True)
(memory_root / "binary.dat").write_bytes(b"\xff\xfe\x80 not utf-8")

with pytest.raises(ToolError, match="is not a valid UTF-8 text file"):
sync_local_filesystem_tool.view(
BetaMemoryTool20250818ViewCommand(command="view", path="/memories/binary.dat")
)

def test_view_error_for_files_with_too_many_lines(
self, sync_local_filesystem_tool: BetaLocalFilesystemMemoryTool
) -> None:
Expand Down Expand Up @@ -635,6 +645,18 @@ async def test_view_error_for_non_existent_file(
BetaMemoryTool20250818ViewCommand(command="view", path="/memories/nonexistent.txt")
)

async def test_view_error_for_non_utf8_file(
self, async_local_filesystem_tool: BetaAsyncLocalFilesystemMemoryTool
) -> None:
memory_root = Path(str(async_local_filesystem_tool.memory_root))
memory_root.mkdir(parents=True, exist_ok=True)
(memory_root / "binary.dat").write_bytes(b"\xff\xfe\x80 not utf-8")

with pytest.raises(ToolError, match="is not a valid UTF-8 text file"):
await async_local_filesystem_tool.view(
BetaMemoryTool20250818ViewCommand(command="view", path="/memories/binary.dat")
)

async def test_view_error_for_files_with_too_many_lines(
self, async_local_filesystem_tool: BetaAsyncLocalFilesystemMemoryTool
) -> None:
Expand Down