Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize hgraph #281

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

optimize hgraph #281

wants to merge 1 commit into from
+10 −12

Conversation

LHT129
Copy link
Collaborator

@LHT129 LHT129 commented Dec 30, 2024 •
edited
Loading

  • disable filter check while filter is nullptr

@LHT129 LHT129 added the kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) label Dec 30, 2024
@LHT129 LHT129 self-assigned this Dec 30, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

wxyucs
wxyucs approved these changes Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@wxyucs wxyucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

inabao
inabao approved these changes Dec 31, 2024
View reviewed changes
Copy link
Collaborator

@inabao inabao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LHT129
disable hgraph filter check when filter is nullptr
c71920f 
- disable filter check while filter is nullptr

Signed-off-by: LHT129 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShawnShawnYou ShawnShawnYou ShawnShawnYou approved these changes

@inabao inabao inabao approved these changes

@wxyucs wxyucs wxyucs approved these changes

Assignees

@LHT129 LHT129

Labels
kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LHT129 @wxyucs @inabao @ShawnShawnYou