vmx: don't inject an OOM exception into the guest on EPT ENOMEM#1
Merged
tianyuzhou95 merged 1 commit intoJun 13, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the guest OOM exception injection mechanism when EPT page allocation fails with -ENOMEM, opting instead to return the error directly to the host. The reviewer identified an issue where setting vcpu->status to SLIMVM_RET_EPT_VIOLATION is a dead store, as it is unconditionally overwritten with SLIMVM_RET_INTERNAL_ERROR in vmx_launch due to the negative return value.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
tianyuzhou95
force-pushed
the
albert/remove-oom-inject
branch
from
6055a45 to
2530773
Compare
Signed-off-by: Tianyu Zhou <albert.zty@antgroup.com>
tianyuzhou95
force-pushed
the
albert/remove-oom-inject
branch
from
2530773 to
15769d7
Compare
btw616
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When EPT page allocation fails with -ENOMEM, the module used to try to inject an OOM exception (T0_OOM_VECTOR) into the guest so the sentry could handle the OOM in GR0, falling back to returning ENOMEM only when injection was not possible.
This patch turns to always return ENOMEM in this case.