fix: replace watchWithFilter with pausableWatch #183
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Infinite loop unexpectedly fixed by
await storageInterface.getItem(key)
in the previous PRThis approach is unreasonable. Relevant discussion
A better approach would be to pause the
watch
when thelocalstroage listen
is triggeredView the commit history, the current code for
useWebExtensionStorage
is based on reference useStorageAsyncuseStorageAsync
here also did not usepausableWatch
becausebrowser
mechanism is different fromextension
Linked Issues
Why does
extension
need to customizeuseStorageAsync
Why use
pausableWatch
to replacewatchWithFilter