Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: respect config file when no explicit cli flags #88

Merged
merged 4 commits into from
Nov 27, 2023
Merged

fix: respect config file when no explicit cli flags #88

merged 4 commits into from
Nov 27, 2023

Conversation

hyoban
Copy link
Contributor

@hyoban hyoban commented Nov 25, 2023

Description

Also fixes some configuration types.

If I got something wrong, please let me know, I will fix it ASAP.

Linked Issues

closes #87

Additional context

@antfu
Copy link
Member

antfu commented Nov 25, 2023

I wonder if we could apply a default to null in the cli options instead of removing them afterwards. The current approach can't differentiate if the option is the default or user set when the value is same.

@hyoban
Copy link
Contributor Author

hyoban commented Nov 26, 2023

@antfu I removed the default config readed from cli. Can you look at it again?

@antfu antfu changed the title fix: config reading order fix: respect config file when no explicit cli flags Nov 27, 2023
@antfu antfu merged commit 27f3c2b into antfu-collective:main Nov 27, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config set from a config file cannot be applied even if the cli does not set the override config
2 participants
@hyoban @antfu