fix: PostgreSQL dollar-tag detection inside quoted strings#1028
Open
Kovania wants to merge 1 commit intoantares-sql:masterfrom
Open
fix: PostgreSQL dollar-tag detection inside quoted strings#1028Kovania wants to merge 1 commit intoantares-sql:masterfrom
Kovania wants to merge 1 commit intoantares-sql:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
querySplitterfunction incorrectly parsed$characters inside single-quoted strings as PostgreSQL dollar-quoted tag delimiters. This caused queries with bcrypt hashes (e.g.,'$2b$12$...') or any string containing$to fail with syntax errors.Solution
Modified the dollar-tag detection logic to only trigger when outside regular quoted strings (
'...'). Dollar-tags are now correctly ignored when inside string literals, while still properly handling legitimate PostgreSQL dollar-quoted blocks like$function$...$function$.Example of fixed query