-
-
Notifications
You must be signed in to change notification settings - Fork 51.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add grayscale colors (neutral palette) to colors.less #31129
Conversation
Codecov Report
@@ Coverage Diff @@
## master #31129 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 397 397
Lines 7561 7570 +9
Branches 2074 2134 +60
=========================================
+ Hits 7561 7570 +9
Continue to review full report at Codecov.
|
Updated to use custom neutral/grayscale palette in bbd18fc: |
I have made the changes. Do you need anything else or can you please review again? |
@afc163 @PeachScript can you review again please? |
@zombieJ 后续统一看看,这是个遗留命名问题,感觉可以下一个大版本统一解决。 |
Conflicting files, I'm sorry to close, can be re initiated if necessary. |
@li-jia-nan I don't think it's worth putting in the effort to re-open this PR if the maintainers won't commit to merging it, especially since the conflicts in this case would have been trivial to resolve. |
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
The antd docs on color palettes mention a gray palette (source):
![image](https://user-images.githubusercontent.com/13430288/123350507-fe251180-d50f-11eb-9ba6-0e481a4ec270.png)
ant-design-colors
also includes a gray palette for use within JS (source)The
![image](https://user-images.githubusercontent.com/13430288/123350388-c6b66500-d50f-11eb-82f5-698554fb6db7.png)
@gray-*
variables are undefined in the colors.less (bundled withantd
) which causes a compiler error if you try to import them:Solution: added variable definitions for gray colors in colors.less
📝 Changelog
@gray-1
through@gray-10
from the Less theme.@gray-1
...@gray-10
☑️ Self Check before Merge