Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: launching a specific version of Sherlock #431

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ansnfernand
Copy link
Collaborator

Checklist:

  • Run unit tests and make sure they all pass
    - Run tests without Sherlock running
    - Run tests with Sherlock GRPC connection
  • Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • Bench test new/modified APIs by using and modifying the code in the example for the API method
  • [] Add new classes to rst files, located at: \doc\source\api
  • Generate documentation
  • Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • Check that test code coverage is at least 80% when Sherlock is running

@ansnfernand ansnfernand added the enhancement New features or code improvements label Oct 28, 2024
@ansnfernand ansnfernand added this to the v0.8.0 milestone Oct 28, 2024
@ansnfernand ansnfernand self-assigned this Oct 28, 2024
@github-actions github-actions bot added the testing Anything related to tests label Oct 28, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 28, 2024
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 68.42105% with 6 lines in your changes missing coverage. Please review.

Project coverage is 56.80%. Comparing base (852f3f4) to head (ef7ae98).

Files with missing lines Patch % Lines
src/ansys/sherlock/core/launcher.py 68.42% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
+ Coverage   56.76%   56.80%   +0.03%     
==========================================
  Files          21       21              
  Lines        4624     4639      +15     
==========================================
+ Hits         2625     2635      +10     
- Misses       1999     2004       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ansnfernand ansnfernand marked this pull request as ready for review October 31, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New features or code improvements testing Anything related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update PySherlock launch_Sherlock() to allow selection of version
2 participants