Fix Incorrect EntityList equality evaluation #537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidanc-ansys
requested review from
jgsdavies,
ravi-ansys,
JackB-Ansys,
matthewAnsys and
james-packer
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #537 +/- ##
==========================================
+ Coverage 88.66% 88.67% +0.01%
==========================================
Files 21 21
Lines 2487 2491 +4
==========================================
+ Hits 2205 2209 +4
Misses 282 282 🚀 New features to boost your workflow:
|
james-packer
requested changes
Jun 20, 2025
| @@ -2139,6 +2139,9 @@ def _entities_same_with_direction(entities_1, entities_2): | |||
| else: | |||
| return False | |||
|
|
|||
| if len(self) != len(entities_to_compare): | |||
| return False | |||
There was a problem hiding this comment.
This code coverage warning is flagging up that there's a subtle problem here. Because our EntityList inherits from list, which defines an empty __ne__(self, other), unless our EntityList re-defines __ne__, != is not the opposite of ==, and checking ent1 != ent2 if ent1 and ent2 are lists, isn't actually calling our comparison code at all!
To resolve this, I think we just need to add a new method in EntityList that is just
def __ne__(self, other):
"""Compare difference of 2 EntityList objects."""
return not self == other
There was a problem hiding this comment.
Ah, thanks! I believe with that, it's now working as it should
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EntityList equality evaluation was previously evaluating whether the first list was a subset of the second. The new behaviour is as expected.