Basic e mag example review #322
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ph method to work with new methods. Updated basic examples
JackB-Ansys
requested review from
jgsdavies,
ravi-ansys and
matthewAnsys
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
==========================================
- Coverage 88.66% 88.58% -0.09%
==========================================
Files 21 21
Lines 2487 2487
==========================================
- Hits 2205 2203 -2
- Misses 282 284 +2 🚀 New features to boost your workflow:
|
| # Define a coil's parameters: | ||
| # :code:`set_winding_coil(phase, | ||
| # path, coil, go_slot, go_position, return_slot, return_position, turns)` | ||
| # .. image:: ../../images/basics_emag_2.png |
There was a problem hiding this comment.
This image doesn't seem to exist?
|
|
||
| print("Simulation completed.") | ||
|
|
||
|
|
||
| # %% | ||
| # Plot results | ||
| # ------------ | ||
| # Plot results from the simulation. | ||
| # Use``pyplot`` from ``matplotlib`` (imported as ``plt``) to plot graphs of the simulation results. | ||
| # Plot the Airgap Flux Density and the Torque (VW) results as subplots in the same figure. | ||
| plt.subplot(211) |
There was a problem hiding this comment.
The X axis title gets cut off on the top graph:
The 'constrained' layout from matplotlib seems to work well for this. I think you can just add plt.figure(layout="constrained") before the plt.subplot(211) call, but I haven't tested this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to EMag basic example. Fixes some issues and enhancements made to comments. Now the harmonic amplitude graph is plotted instead of the torque being plotted twice.