-
Notifications
You must be signed in to change notification settings - Fork 59
feat: Update server based enhanced meshing workflow. #4779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update server based enhanced meshing workflow. #4779
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances the server-based meshing workflow by introducing new functionality for creating and loading workflows, while restricting fault-tolerant specific attributes to their appropriate workflow types.
Key changes:
- Introduces
create_workflow()API with insertable task support for dynamically building workflows - Adds attribute access control to prevent
partsandparts_filesfrom being accessed in non-fault-tolerant workflows - Implements
load_workflow()functionality with test coverage
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_server_meshing_workflow.py | Adds comprehensive tests for create_workflow() with insertable tasks and load_workflow() functionality |
| src/ansys/fluent/core/workflow_new.py | Implements insertable tasks infrastructure, adds attribute access restrictions for fault-tolerant specific features, and fixes memory leak by deleting command instances |
| src/ansys/fluent/core/meshing/meshing_workflow_new.py | Adds parts and parts_files properties to task objects for fault-tolerant workflow access |
| doc/source/user_guide/meshing/new_meshing_workflows.rst | Corrects documentation path from "meshing_workflow" to "meshing_workflows" |
| doc/changelog.d/4779.added.md | Documents the feature addition in changelog |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Context
Test has been added for the above case.
Change Summary
Existing logic and tests were migrated.
Rationale
Simplest approach to make the existing tests work.
Impact
No direct impact to users.