Skip to content

Conversation

@prmukherj
Copy link
Collaborator

@prmukherj prmukherj commented Jan 2, 2026

Context

  1. "parts" and "parts-files" should only be accessible from Fault Tolerant workflows. It should not appear in the dir of the other workflows and also should raise Attribute error if tried to access from other workflow types.
  2. "create_workflow" is introduced with insertable task list for initial set of tasks that can be inserted.
created_workflow = meshing_session.create_workflow()
created_workflow.insertable_tasks.import_geometry.insert()
created_workflow.import_geometry.file_name.set_state(import_file_name)
created_workflow.import_geometry.length_unit.set_state('in')
created_workflow.import_geometry()

Test has been added for the above case.

  1. Added test for "load_workflow".

Change Summary

Existing logic and tests were migrated.

Rationale

Simplest approach to make the existing tests work.

Impact

No direct impact to users.

@github-actions github-actions bot added the documentation Documentation related (improving, adding, etc) label Jan 2, 2026
@prmukherj prmukherj marked this pull request as ready for review January 2, 2026 10:38
Copilot AI review requested due to automatic review settings January 2, 2026 10:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the server-based meshing workflow by introducing new functionality for creating and loading workflows, while restricting fault-tolerant specific attributes to their appropriate workflow types.

Key changes:

  • Introduces create_workflow() API with insertable task support for dynamically building workflows
  • Adds attribute access control to prevent parts and parts_files from being accessed in non-fault-tolerant workflows
  • Implements load_workflow() functionality with test coverage

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/test_server_meshing_workflow.py Adds comprehensive tests for create_workflow() with insertable tasks and load_workflow() functionality
src/ansys/fluent/core/workflow_new.py Implements insertable tasks infrastructure, adds attribute access restrictions for fault-tolerant specific features, and fixes memory leak by deleting command instances
src/ansys/fluent/core/meshing/meshing_workflow_new.py Adds parts and parts_files properties to task objects for fault-tolerant workflow access
doc/source/user_guide/meshing/new_meshing_workflows.rst Corrects documentation path from "meshing_workflow" to "meshing_workflows"
doc/changelog.d/4779.added.md Documents the feature addition in changelog

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings January 6, 2026 06:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings January 7, 2026 07:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings January 7, 2026 12:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings January 7, 2026 12:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@prmukherj prmukherj merged commit c12387d into main Jan 9, 2026
33 checks passed
@prmukherj prmukherj deleted the feat/update_server_based_enhanced_meshing_workflow branch January 9, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Documentation related (improving, adding, etc) new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants