fix: Fix test_strings_with_allowed_values #4646
Merged
+8
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkundu1
requested review from
hpohekar,
mayankansys,
prmukherj and
seanpearsonuk
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes two failing tests in the test suite. The first fix addresses test_strings_with_allowed_values by conditionally checking the case_frequency.allowed_values() assertion only for Fluent version 26.1 and later. The second change disables test_accessor_methods_on_settings_objects due to a known issue tracked in GitHub issue #4645.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
prmukherj
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix test_strings_with_allowed_values which is failing in the main branch.
Disable test_accessor_methods_on_settings_objects which is failing with the latest 26.1 image.