Skip to content

Conversation

hpohekar
Copy link
Collaborator

Context

Notifications job is skipped every time which is not expected.

Change Summary

We are sending notifications for both success and failure.

Rationale

The condition job.status != 'success' will always be false when evaluated. The job.status is not available during step execution and only becomes available in post-job hooks.

Impact

Send GitHub Actions Run Status Adaptive Card to Teams via Power Automate step only.

@Copilot Copilot AI review requested due to automatic review settings October 16, 2025 11:33
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes GitHub Actions workflow notifications that were being skipped due to incorrect conditional logic. The issue was that job.status is not available during step execution, causing the notification steps to never run.

  • Updated conditional logic to use always() instead of checking job.status != 'success'
  • Ensures notifications are sent for both successful and failed scheduled runs
  • Maintains the existing logic within the script to determine actual status

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/test-run-dev-version-nightly.yml Fixed notification step condition to run on all scheduled executions
.github/workflows/test-podman-compose.yml Fixed notification step condition to run on all scheduled executions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added maintenance General maintenance of the repo (libraries, cicd, etc) CI/CD Related to CI/CD labels Oct 16, 2025
@hpohekar hpohekar closed this Oct 16, 2025
@hpohekar hpohekar reopened this Oct 16, 2025
## Context
What was the situation or problem before this change?

## Change Summary
What changes were made?

## Rationale
Why was this approach taken?

## Impact
What parts of the system or workflows are affected?

---------

Co-authored-by: pyansys-ci-bot <[email protected]>
@Copilot Copilot AI review requested due to automatic review settings October 16, 2025 16:34
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

mkundu1 and others added 2 commits October 20, 2025 08:17
Notify only if the status from the testing step is not success

---------

Co-authored-by: pyansys-ci-bot <[email protected]>
@Copilot Copilot AI review requested due to automatic review settings October 20, 2025 03:36
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@hpohekar hpohekar merged commit a699e8e into main Oct 20, 2025
36 checks passed
@hpohekar hpohekar deleted the ci/fix_notifications branch October 20, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Related to CI/CD maintenance General maintenance of the repo (libraries, cicd, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants