-
Notifications
You must be signed in to change notification settings - Fork 56
ci: Fix notifications [skip tests] #4560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes GitHub Actions workflow notifications that were being skipped due to incorrect conditional logic. The issue was that job.status
is not available during step execution, causing the notification steps to never run.
- Updated conditional logic to use
always()
instead of checkingjob.status != 'success'
- Ensures notifications are sent for both successful and failed scheduled runs
- Maintains the existing logic within the script to determine actual status
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
.github/workflows/test-run-dev-version-nightly.yml | Fixed notification step condition to run on all scheduled executions |
.github/workflows/test-podman-compose.yml | Fixed notification step condition to run on all scheduled executions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
## Context What was the situation or problem before this change? ## Change Summary What changes were made? ## Rationale Why was this approach taken? ## Impact What parts of the system or workflows are affected? --------- Co-authored-by: pyansys-ci-bot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Notify only if the status from the testing step is not success --------- Co-authored-by: pyansys-ci-bot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Context
Notifications job is skipped every time which is not expected.
Change Summary
We are sending notifications for both success and failure.
Rationale
The condition job.status != 'success' will always be false when evaluated. The job.status is not available during step execution and only becomes available in post-job hooks.
Impact
Send GitHub Actions Run Status Adaptive Card to Teams via Power Automate
step only.