Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove settings API hash comparison and runtime generation of settings API classes #3399

Merged
merged 2 commits into from
Oct 27, 2024

Conversation

mkundu1
Copy link
Contributor

@mkundu1 mkundu1 commented Oct 16, 2024

This PR removes settings API hash comparison and runtime generation of settings API classes. This is not required anymore because:

  • In PyConsole, we don't use this mechanism. The latest settings API classes are always generated while building Fluent.
  • In released versions of PyFluent, the settings API classes generated from the latest Fluent images are up-to-date.
  • This was useful only during the local development of PyFluent to avoid running settingsgen after updating the Fluent code. However, it is better to run settingsgen in this case so the generated files are used and tested during local development. Note that, we can run just settingsgen as python src\ansys\fluent\core\codegen\settingsgen.py which takes much less time than full codegen.

This PR saves 4s during the first settings API access at runtime.

@mkundu1 mkundu1 merged commit cce4bcc into main Oct 27, 2024
26 checks passed
@mkundu1 mkundu1 deleted the fix/remove-hash-check branch October 27, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dir(solver_session) is slow for the first time after connecting to Fluent
4 participants