Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding save_path to some examples #31

Merged
merged 6 commits into from
May 15, 2023
Merged

Adding save_path to some examples #31

merged 6 commits into from
May 15, 2023

Conversation

raph-luc
Copy link
Member

@raph-luc raph-luc commented May 12, 2023

Addressing #25, adding the option to save to user-specified paths in some of the examples, also making various smaller fixes in attempts to get the examples to work on Fluent v231 and v232

As most of the examples do not properly kill running processes (e.g. using session.exit()), I have been changing them to show the gui when running (show_gui=True), also makes them easier to dev and debug, and I think having the gui works better for the examples overall. edit: see comments below, rather than using show_gui, added session.exit()s to the examples that were missing it

Related issues:
#28 - 'Ablation' still not working correctly
#29 - 'Separator-Collection-Efficiency' preliminary fix in this branch
#30 - 'Steady-Vortex-VOF' still not working correctly

Will continue to work through the examples as time allows in future branches/PRs

@github-actions github-actions bot added the enhancement New features or code improvements label May 12, 2023
@raph-luc raph-luc added the bug Something isn't working label May 12, 2023
@mkundu1
Copy link
Collaborator

mkundu1 commented May 12, 2023

@raph-luc Thanks for fixing the examples for the latest version of Fluent. Few suggestions:

  1. It is sufficient that the examples work only with the latest release of Fluent, which is 23.2 (will soon become 24.1). We don't need to maintain them for 23.1 or previous versions.
  2. At some point we would like to execute the examples in the CI (Repo cleanup #26). show_gui will not work there. Also, most pyfluent usage assumes that Fluent is running headless.

@raph-luc
Copy link
Member Author

As discussed with @mkundu1, some additional changes to how pyfluent by default handles CWD (particularly saving examples to CWD through download_file rather than EXAMPLES_PATH with implications for the CI testing) may be in order, to make it more intuitive for end users. Having so many examples with save_path may then be unnecessary, but I believe that would best be left for another issue and PR with bigger related changes, can easily trim down the examples later.

@raph-luc raph-luc requested a review from mkundu1 May 12, 2023 21:13
@raph-luc raph-luc merged commit 3fcce0e into main May 15, 2023
@raph-luc raph-luc deleted the feat/save_path branch May 15, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants