Skip to content

test: adding test coverage for designer, sketch, misc #2070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 27, 2025

Conversation

syscordan
Copy link
Contributor

Description

adding test coverage for designer, sketch, misc*

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

Sorry, something went wrong.

@syscordan syscordan self-assigned this Jun 25, 2025
@syscordan syscordan requested a review from a team as a code owner June 25, 2025 15:28
@syscordan syscordan added the testing Anything related to tests label Jun 25, 2025
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.84%. Comparing base (12242ce) to head (ac63bf4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2070      +/-   ##
==========================================
+ Coverage   92.61%   92.84%   +0.23%     
==========================================
  Files         136      136              
  Lines        9812     9812              
==========================================
+ Hits         9087     9110      +23     
+ Misses        725      702      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments - thanks for the tests @syscordan!

…b.com/ansys/pyansys-geometry into test/syscordan_designer_misc_coverage

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some last comments @syscordan - just for separation of concerns. Thanks!

syscordan and others added 3 commits June 27, 2025 11:57
…b.com/ansys/pyansys-geometry into test/syscordan_designer_misc_coverage

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RobPasMue RobPasMue enabled auto-merge (squash) June 27, 2025 18:00
@RobPasMue RobPasMue merged commit da919ad into main Jun 27, 2025
44 checks passed
@RobPasMue RobPasMue deleted the test/syscordan_designer_misc_coverage branch June 27, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Anything related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants