-
Notifications
You must be signed in to change notification settings - Fork 19
feat: add components to NS #2068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
tested with a box
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha.. sounds good! LGTM
This might need some server side fix. Which means that we should also warn that components can only be translated starting on 26R1 I guess - unless we plan on adding this feature to a SP for 25R2. |
reverted changes to move_translate
…nsys/pyansys-geometry into feat/move_translate_components
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2068 +/- ##
==========================================
- Coverage 92.61% 91.85% -0.76%
==========================================
Files 136 136
Lines 9812 9825 +13
==========================================
- Hits 9087 9025 -62
- Misses 725 800 +75 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
added a test to fetch components from NS
…nsys/pyansys-geometry into feat/move_translate_components
Description
Issue linked
#2067
Checklist
feat: extrude circle to cylinder
)