Skip to content

fix!: Adapt to new visualizer version #2055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 20, 2025

Conversation

AlejandroFernandezLuces
Copy link
Contributor

@AlejandroFernandezLuces AlejandroFernandezLuces commented Jun 20, 2025

Description

Adapts PyAnsys Geometry to the new version of the visualization tool. This changes some user facing interfaces, so I marked the commit as breaking.

Issue linked

Associated PR #2054

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@github-actions github-actions bot added the bug Something isn't working label Jun 20, 2025
Copy link

codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.31%. Comparing base (6f0d394) to head (0da09a1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2055      +/-   ##
==========================================
- Coverage   92.31%   92.31%   -0.01%     
==========================================
  Files         136      136              
  Lines        9811     9810       -1     
==========================================
- Hits         9057     9056       -1     
  Misses        754      754              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added the maintenance Package and maintenance related label Jun 20, 2025
@AlejandroFernandezLuces AlejandroFernandezLuces changed the title fix: Adapt to new visualizer version fix!: Adapt to new visualizer version Jun 20, 2025
@AlejandroFernandezLuces AlejandroFernandezLuces marked this pull request as ready for review June 20, 2025 07:38
@AlejandroFernandezLuces AlejandroFernandezLuces requested a review from a team as a code owner June 20, 2025 07:38
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix @AlejandroFernandezLuces - much appreciated. Just a minor comment

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlejandroFernandezLuces AlejandroFernandezLuces enabled auto-merge (squash) June 20, 2025 13:27
@AlejandroFernandezLuces AlejandroFernandezLuces merged commit 38ee044 into main Jun 20, 2025
45 checks passed
@AlejandroFernandezLuces AlejandroFernandezLuces deleted the fix/new-viz-version branch June 20, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants