-
Notifications
You must be signed in to change notification settings - Fork 19
fix!: Adapt to new visualizer version #2055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2055 +/- ##
==========================================
- Coverage 92.31% 92.31% -0.01%
==========================================
Files 136 136
Lines 9811 9810 -1
==========================================
- Hits 9057 9056 -1
Misses 754 754 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…s-geometry into fix/new-viz-version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the fix @AlejandroFernandezLuces - much appreciated. Just a minor comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Adapts PyAnsys Geometry to the new version of the visualization tool. This changes some user facing interfaces, so I marked the commit as breaking.
Issue linked
Associated PR #2054
Checklist
feat: extrude circle to cylinder
)