-
Notifications
You must be signed in to change notification settings - Fork 20
feat: NURBSCurve conversions #2053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2053 +/- ##
==========================================
- Coverage 92.85% 92.74% -0.12%
==========================================
Files 137 137
Lines 9894 9909 +15
==========================================
+ Hits 9187 9190 +3
- Misses 707 719 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… feat/nurbs_conversion_to_proto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Co-authored-by: Maxime Rey <[email protected]>
… feat/nurbs_conversion_to_proto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @jacobrkerstetter
Description
added functionality to pass NURBS across as GRPC layers as CurveGeometry
Issue linked
Checklist
feat: extrude circle to cylinder
)