Skip to content

feat: NURBSCurve conversions #2053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 2, 2025
Merged

Conversation

jacobrkerstetter
Copy link
Contributor

@jacobrkerstetter jacobrkerstetter commented Jun 19, 2025

Description

added functionality to pass NURBS across as GRPC layers as CurveGeometry

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

Sorry, something went wrong.

@jacobrkerstetter jacobrkerstetter self-assigned this Jun 19, 2025
@github-actions github-actions bot added the enhancement New features or code improvements label Jun 19, 2025
pyansys-ci-bot and others added 2 commits June 19, 2025 18:01
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 92.74%. Comparing base (443a380) to head (61653e6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ys/geometry/core/_grpc/_services/v0/conversions.py 20.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2053      +/-   ##
==========================================
- Coverage   92.85%   92.74%   -0.12%     
==========================================
  Files         137      137              
  Lines        9894     9909      +15     
==========================================
+ Hits         9187     9190       +3     
- Misses        707      719      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

… feat/nurbs_conversion_to_proto
@jacobrkerstetter jacobrkerstetter marked this pull request as ready for review June 27, 2025 18:47
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner June 27, 2025 18:47

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
MaxJPRey
MaxJPRey previously approved these changes Jul 1, 2025
Copy link
Contributor

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Maxime Rey <[email protected]>
… feat/nurbs_conversion_to_proto
@jacobrkerstetter jacobrkerstetter enabled auto-merge (squash) July 2, 2025 14:28
@jacobrkerstetter jacobrkerstetter requested a review from MaxJPRey July 2, 2025 14:48
Copy link
Contributor

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @jacobrkerstetter

@jacobrkerstetter jacobrkerstetter merged commit a7a2265 into main Jul 2, 2025
44 checks passed
@jacobrkerstetter jacobrkerstetter deleted the feat/nurbs_conversion_to_proto branch July 2, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants