-
Notifications
You must be signed in to change notification settings - Fork 17
feat: update with delta #1922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: update with delta #1922
Conversation
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: pyansys-ci-bot <[email protected]> Co-authored-by: Roberto Pastor Muela <[email protected]>
…nsys-geometry into feat/update-with-delta
Codecov ReportAttention: Patch coverage is
❌ Your project check has failed because the head coverage (89.39%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1922 +/- ##
==========================================
- Coverage 90.50% 89.39% -1.12%
==========================================
Files 136 136
Lines 9787 9949 +162
==========================================
+ Hits 8858 8894 +36
- Misses 929 1055 +126 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like all the tests have gone through in the end @umutsoysalansys! Are you still experiencing issues locally? I left a first review with some comments. Let me know once I can do a final review. Thanks for all the work here, this looks promising!
…nsys-geometry into feat/update-with-delta
…nsys-geometry into feat/update-with-delta
…nsys-geometry into feat/update-with-delta
…nsys-geometry into feat/update-with-delta
Yes because it is also behind the feature flag which is set to False as default ( so update design inplace is activated) The full test suit with the tracker is still failing in 2 tests because of some potential leak on Geometry Service side but all tests are passing individually and still following up on that issue with @david-gorman @b-matteo. Once it is resumed we can working on changing the flag with extensive testing. |
Oh you are completely right! I missed that part.. I need to get back on the debugging as well, thanks for clarifying it @umutsoysalansys! I did some early debugging on Friday and Monday but nothing clear popped up yet... let's see if I can continue to investigate as well on my side. Thanks a lot for all the refactoring and answering all comments! |
Description
** This Pr introduces a new method to update design object using new trackers coming from API Server. Currently we are trying to keep the synchronization between client and server by updating whole design document after each operation that can possibly cause a change on the backend which is an expensive effort. Recently developed trackers are allowing us to get the only delta from each geometry manipulation operation and the method in this PR updates the design recursively using the information coming from tracker.
It is currently hidden behind a feature flag, for extensive testing and further improvements. **
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist
feat: extrude circle to cylinder
)