-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add chamfer tool #1495
base: main
Are you sure you want to change the base?
feat: add chamfer tool #1495
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good at first sight. Again, I would initiate a "Pull tools" example module to host how to use them. We need examples for all these new features.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @jonahrb! However, we are having some issues with the Docker images as you might have seen. Hope to see this merged soon. I'll leave it approved!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah wait - documentation example is missing. I'll leave the approval for whenever that's done
@RobPasMue yes working on that now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor edits suggested on doc content.
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Create chamfer on an edge, or adjust the chamfer of a face. This is available on Linux via the CoreService. Created "pull_tools" to house all the incoming geometry commands that will all be available on windows+linux.
Issue linked
Checklist
feat: extrude circle to cylinder
)