Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Arbitrary waveport extension driven terminal mode fix #5737

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

svandenb-dev
Copy link
Collaborator

Description

This PR fix the bug with extension for arbitrary wave port generation be enabling HFSS driven terminal instead of modal.

closing #5736

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.18%. Comparing base (b484a4b) to head (0ca6012).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5737      +/-   ##
==========================================
+ Coverage   81.48%   85.18%   +3.69%     
==========================================
  Files         156      156              
  Lines       61063    61063              
==========================================
+ Hits        49760    52018    +2258     
+ Misses      11303     9045    -2258     

@svandenb-dev svandenb-dev enabled auto-merge (squash) February 6, 2025 08:26
Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@svandenb-dev svandenb-dev merged commit 6953254 into main Feb 6, 2025
43 checks passed
@svandenb-dev svandenb-dev deleted the arbitrary-wave-port-driven-terminal-fix branch February 6, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: arbitrary wave port is generating 3D component with driven model mode instead of terminal
3 participants