Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: General improvements in Icepak #5728

Merged
merged 14 commits into from
Feb 9, 2025

Conversation

SMoraisAnsys
Copy link
Collaborator

Description

Follow up of #5695 applied to Icepak

Issue linked

Associated to #5504

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 18 lines in your changes missing coverage. Please review.

Project coverage is 84.78%. Comparing base (ea83212) to head (135fcbd).
Report is 1 commits behind head on main.

❌ Your patch status has failed because the patch coverage (57.14%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5728      +/-   ##
==========================================
+ Coverage   84.76%   84.78%   +0.01%     
==========================================
  Files         157      157              
  Lines       61634    61615      -19     
==========================================
- Hits        52245    52240       -5     
+ Misses       9389     9375      -14     

src/ansys/aedt/core/icepak.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/icepak.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/generic/constants.py Outdated Show resolved Hide resolved
@SMoraisAnsys
Copy link
Collaborator Author

@Samuelopez-ansys This PR has been reviewed by @lorenzovecchietti
JSYK, after discussing with Lorenzo, the previous solution type values have been updated. Previously, the values were the one displayed in AEDT UI but since the value are not leveraged in the code with the same name, we have moved to SteadyState and Transient only.

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) February 9, 2025 21:31
@Samuelopez-ansys Samuelopez-ansys merged commit af215f9 into main Feb 9, 2025
42 of 43 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the refactor/icepak-improvements branch February 9, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants